Skip to content

REF: Refactor private/circular parts out of dtypes.concat #25273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Feb 11, 2019 · 0 comments
Closed

REF: Refactor private/circular parts out of dtypes.concat #25273

jbrockmendel opened this issue Feb 11, 2019 · 0 comments
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code

Comments

@jbrockmendel
Copy link
Member

A lot of core.dtypes.concat arguably doesn't belong in core.dtypes. In particular functions that induce circular imports, private functions that are used externally, and functions that are more about arrays/indexes than they are about dtypes.

Some of these (_get_series_result_type, _get_frame_result_type) are used in only core.reshape.concat, could go either directly in that module or into a helper module in core.reshape.

Others are class-specific (concat_rangeindex_same_dtype, _concat_sparse, concat_index_asobject) and make more sense in the modules corresponding to those classes (avoiding circular imports). union_categoricals and _concat_categorical probably belong in this group too.

_concat_compat is used in 6 other files, probably shouldn't be private.

@mroeschke mroeschke added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

No branches or pull requests

2 participants