Skip to content

DOC: Fix flake8 issues in doc/source/whatsnew/v0.12.*.rst #24257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurav2608 opened this issue Dec 13, 2018 · 1 comment · Fixed by #24309
Closed

DOC: Fix flake8 issues in doc/source/whatsnew/v0.12.*.rst #24257

saurav2608 opened this issue Dec 13, 2018 · 1 comment · Fixed by #24309

Comments

@saurav2608
Copy link

saurav2608 commented Dec 13, 2018

xref: #24177

We didn't start validating the format of PEP8 and other code standards in the documentation examples until recently. We still have some files with errors, that we need to skip, and that we should fix, so we can start validating them.

Two steps are required to replicate the issue

  1. Edit setup.cfg in the pandas home, and in the flake8-rst section, remove from the exclude list the file doc/source/whatsnew/v0.12.0.rst

  2. Remove the import block ( from pandas import *) from the lines (8-11) of the file v0.12.0.rst.

After that, running the next command will report the errors in the file (note that syntax error usually prevent to validate other errors, and the list of errors to fix can become much longer when the syntax error is fixed (please make sure that you are using flake8-rst version 0.7.0 or higher):

$ flake8-rst doc/source/whatsnew/v0.12.*
doc/source/whatsnew/v0.12.0.rst:50:24: E201 whitespace after '{'
doc/source/whatsnew/v0.12.0.rst:50:32: E203 whitespace before ':'
doc/source/whatsnew/v0.12.0.rst:50:37: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:50:39: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:50:52: E203 whitespace before ':'
doc/source/whatsnew/v0.12.0.rst:50:57: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:50:59: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:50:62: E202 whitespace before '}'
doc/source/whatsnew/v0.12.0.rst:64:44: E203 whitespace before ':'
doc/source/whatsnew/v0.12.0.rst:64:59: E231 missing whitespace after ':'
doc/source/whatsnew/v0.12.0.rst:65:33: E231 missing whitespace after ':'
doc/source/whatsnew/v0.12.0.rst:65:57: E231 missing whitespace after ':'
doc/source/whatsnew/v0.12.0.rst:67:33: E221 multiple spaces before operator
doc/source/whatsnew/v0.12.0.rst:90:20: E228 missing whitespace around modulo operator
doc/source/whatsnew/v0.12.0.rst:245:41: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:245:43: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:245:45: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:245:62: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:262:36: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:262:52: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:262:57: E231 missing whitespace after ','
doc/source/whatsnew/v0.12.0.rst:323:10: E112 expected an indented block
doc/source/whatsnew/v0.12.0.rst:323:11: E999 IndentationError: expected an indented block

Once all the errors are addressed, please open a pull request with the fixes in the file, and removing the file from setup.cfg. If you need to do something that feels wrong to fix an error, please ask in a comment to this issue. Please avoid other unrelated changes, which can be addressed in a separate pull request.
cc: @datapythonista

@saurav2608
Copy link
Author

saurav2608 commented Dec 16, 2018

I am taking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants