Skip to content

Add tests asserting that EAs shouldn't be coerced to ndarray #24207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TomAugspurger opened this issue Dec 10, 2018 · 0 comments
Open

Add tests asserting that EAs shouldn't be coerced to ndarray #24207

TomAugspurger opened this issue Dec 10, 2018 · 0 comments
Labels
Categorical Categorical Data Type Enhancement Testing pandas testing functions or related to the test suite

Comments

@TomAugspurger
Copy link
Contributor

#24204 introduced a pattern for ensuring that an extension array (like categorical) isn't implicitly converted to an ndarray as part of a normal pandas operation.

This issue is to discuss

  1. How these kinds of tests could be better written (is monkeypatching the best choice?)
  2. Additional places where we should be making these assertions
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite Categorical Categorical Data Type labels Dec 10, 2018
@TomAugspurger TomAugspurger added this to the Contributions Welcome milestone Dec 10, 2018
@TomAugspurger TomAugspurger mentioned this issue Dec 10, 2018
Merged
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Categorical Categorical Data Type Enhancement Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomAugspurger @mroeschke