Skip to content

CLN: move generic code to NDFrame #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Dec 3, 2012 · 2 comments
Closed

CLN: move generic code to NDFrame #2414

jreback opened this issue Dec 3, 2012 · 2 comments
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Dec 3, 2012

thinking of:

lots of parts of align
comparison ops,
parts of apply (and put special cases in the sub-classes)
pop
align & where

@paulproteus
Copy link

I notice that the 'def pop()' in pandas/core/frame.py simply calls out to NDFrame.pop(self, item). It seems to me that the implementation will automatically call out to NDFrame since DataFrame is defined as a subclass of NDFrame.

A question for pandas core maintainers: is the right fix for pop() to just delete it from DataFrame?

For the other methods, more creativity may be required.

For anyone interested in addressing this issue: The great thing about pandas having a test suite is that you can willy-nilly delete, or move, code and see if it breaks pandas by just running the test suite!

@jreback
Copy link
Contributor Author

jreback commented Feb 22, 2013

closing in favor of PR #2915

@jreback jreback closed this as completed Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants