Skip to content

Cython language_level Warning - switch to Python3? #23927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd opened this issue Nov 26, 2018 · 5 comments · Fixed by #24538
Closed

Cython language_level Warning - switch to Python3? #23927

WillAyd opened this issue Nov 26, 2018 · 5 comments · Fixed by #24538
Labels
Build Library building on various platforms
Milestone

Comments

@WillAyd
Copy link
Member

WillAyd commented Nov 26, 2018

When compiling with Cython the following warning gets issued:

Cython/Compiler/Main.py:367: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: clones/pandas/pandas/_libs/groupby.pxd

Haven't looked into the implications as of yet but probably worth switching to Python3, especially given the upcoming drop of Python2 support

@WillAyd WillAyd added the Build Library building on various platforms label Nov 26, 2018
@jbrockmendel
Copy link
Member

Have you tried this locally? For me it causes python setup.py build_ext --inplace to fail

@WillAyd
Copy link
Member Author

WillAyd commented Nov 27, 2018

Yea it failed pretty miserably. Just for the sake of explicitness I updated the setup.py to have the following line:

directives = {'linetrace': False, 'language_level': 3}

Haven't looked in detail but assume it's an issue with how we are doing imports

@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

what is next on the list for this?

@WillAyd
Copy link
Member Author

WillAyd commented Jan 1, 2019

I think mostly minor stuff around division differences. There’s also one fused type containing Unicode which was failing before for Py27 builds.

Most of this was wrapped up in 62bee57 - is the Py27 failure something we need to worry about after 0.24 release?

@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

no issue for 0.24.0, just saw the warnings and led me here :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants