Skip to content

__finalize__ consistency DataFrame vs SparseDataFrame #23028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Oct 7, 2018 · 2 comments
Closed

__finalize__ consistency DataFrame vs SparseDataFrame #23028

jbrockmendel opened this issue Oct 7, 2018 · 2 comments
Labels
Internals Related to non-user accessible pandas implementation

Comments

@jbrockmendel
Copy link
Member

SparseDataFrame arithmetic (and some comparison) ops call .__finalize__(self) before returning. DataFrame ops do not. Is this intentional?
@jbrockmendel
Copy link
Member Author

Related: it looks like a lot of these are written under the assumption that columns are unique. Is that a convention for SparseDataFrame?

@jbrockmendel
Copy link
Member Author

Related: #13208

@jbrockmendel jbrockmendel mentioned this issue Nov 1, 2018
Closed
@mroeschke mroeschke added the Internals Related to non-user accessible pandas implementation label Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @mroeschke