Skip to content

ENH: allow passing a mask to nanops to facilitate EA reduction ops #22764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Sep 19, 2018 · 1 comment · Fixed by #22865
Closed

ENH: allow passing a mask to nanops to facilitate EA reduction ops #22764

jreback opened this issue Sep 19, 2018 · 1 comment · Fixed by #22865
Labels
Enhancement ExtensionArray Extending pandas with custom dtypes or arrays. Performance Memory or execution speed performance
Milestone
0.24.0

Comments

@jreback
Copy link
Contributor

jreback commented Sep 19, 2018

#22762 (comment)

currently we call nanops like

nansum(values, skipna=boolean)

this doesn't allow us to take advantage of knowing the nan mask a-priori (e.g. in an IntegerArray), and instead re-computes it based on the values (only).

We could allow skipna= to take a mask as well here (or add a mask= keyword) to facilitate this.
@jreback jreback added Enhancement Performance Memory or execution speed performance Difficulty Intermediate ExtensionArray Extending pandas with custom dtypes or arrays. labels Sep 19, 2018
@jreback jreback added this to the Contributions Welcome milestone Sep 19, 2018
@alimcmaster1
Copy link
Member

Ill take a look at adding this :)

@alimcmaster1 alimcmaster1 mentioned this issue Sep 27, 2018
Merged
4 tasks
@jreback jreback modified the milestones: Contributions Welcome, 0.24.0 Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ExtensionArray Extending pandas with custom dtypes or arrays. Performance Memory or execution speed performance
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Allow passing a mask to NanOps
2 participants
@jreback @alimcmaster1