Skip to content

COMPAT: handle numpy 1.15 deprecation warnings #22101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Jul 28, 2018 · 4 comments
Closed

COMPAT: handle numpy 1.15 deprecation warnings #22101

jreback opened this issue Jul 28, 2018 · 4 comments
Labels
Compat pandas objects compatability with Numpy or Python functions
Milestone
0.24.0

Comments

@jreback
Copy link
Contributor

jreback commented Jul 28, 2018

I think this is a new warning from numpy in 1.15: https://travis-ci.org/pandas-dev/pandas/jobs/409274058

/home/travis/build/pandas-dev/pandas/pandas/core/dtypes/common.py:2026: DeprecationWarning: elementwise == comparison failed; this will raise an error in the future.
    if dtype in [object, np.object_, 'object', 'O']:
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Jul 28, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 28, 2018
@jreback
Copy link
Contributor Author

jreback commented Jul 28, 2018

cc @charris

@charris
Copy link

charris commented Jul 28, 2018

The DeprecationWarning has been around since NumPy 1.10, what is new is numpy/numpy#10337. Note the Pandas comments in the referenced issue numpy/numpy#5188. I think Pandas may have had a workaround that now fails.

@charris
Copy link

charris commented Jul 28, 2018

Although I suppose something else may have changed so that that path is now taken. Probably would need to bisect to verify the cause.

@jreback jreback mentioned this issue Jul 31, 2018
Merged
@jreback
Copy link
Contributor Author

jreback commented Aug 1, 2018

closed by #22142

@jreback jreback closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
2 participants
@charris @jreback