Skip to content

iloc calls should not reach indexes code #21989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toobaz opened this issue Jul 20, 2018 · 4 comments
Closed

iloc calls should not reach indexes code #21989

toobaz opened this issue Jul 20, 2018 · 4 comments
Labels
Clean Closing Candidate May be closeable, needs more eyeballs Indexing Related to indexing on series/frames, not to indexes themselves

Comments

@toobaz
Copy link
Member

toobaz commented Jul 20, 2018

Related to #21982, which however only fixes one particular case: there are more.

Will soon push a branch with more substantial changes - which however is still not ready (breaks some tests).

@toobaz toobaz added Indexing Related to indexing on series/frames, not to indexes themselves Clean labels Jul 20, 2018
@toobaz toobaz changed the title iloc calls should not touch indexes code iloc calls should not reach indexes code Jul 20, 2018
@toobaz
Copy link
Member Author

toobaz commented Jul 20, 2018

This is the branch I was mentioning: https://github.com/toobaz/pandas/tree/iloc_with_non_int_round2

I'll try look at the broken tests in August.

@jbrockmendel
Copy link
Member

@toobaz is this still an issue? there's been quite some refactoring since it was opened

@toobaz
Copy link
Member Author

toobaz commented Sep 21, 2020

@jbrockmendel I think this is fixed. Mostly because #32477 fixed #15686 . What leaves me uncertain is that #32477 specifically mentions "with duplicates"... but I guess the non-duplicated cases was already fixed. And unfortunately I don't have time to do much research now.

(It would be cool to have a broken index class to pass to Series and DataFrames for testing iloc, which would always raise an error when actually used for indexing!)

@jbrockmendel
Copy link
Member

(It would be cool to have a broken index class to pass to Series and DataFrames for testing iloc, which would always raise an error when actually used for indexing!)

That might be a nice way to test somethings. For now I think this is closeable.

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Closing Candidate May be closeable, needs more eyeballs Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

No branches or pull requests

2 participants