You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a handful of places in the code where we check for for isinstance(other, ABCDatetimeIndex) or getattr(other, '_typ', None) == "datetimeindex" (and analogous places for TDI, PI). In most of these cases DatetimeArray/TimedeltaArray/PeriodArray should be handled symmetrically. Thoughts on what _typs to give them?
The text was updated successfully, but these errors were encountered:
Well there is an ABCExtensionArray. For some of it we can probably get away with changing e.g isinstance(foo, ABCPeriodIndex) to is_period_dtype(foo). The cython cases that explicitly check _typ will need special handling.
There are a handful of places in the code where we check for for
isinstance(other, ABCDatetimeIndex)
orgetattr(other, '_typ', None) == "datetimeindex"
(and analogous places for TDI, PI). In most of these cases DatetimeArray/TimedeltaArray/PeriodArray should be handled symmetrically. Thoughts on what_typ
s to give them?The text was updated successfully, but these errors were encountered: