Skip to content

Typo in error message in the PlanePlot class #21347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pjk645-zz opened this issue Jun 6, 2018 · 4 comments · Fixed by #21350
Closed

Typo in error message in the PlanePlot class #21347

pjk645-zz opened this issue Jun 6, 2018 · 4 comments · Fixed by #21350

Comments

@pjk645-zz
Copy link

The error message should probably read: ' requires an x and a y column' not ' requires and x and y column'

raise ValueError(self._kind + ' requires and x and y column')

@WillAyd
Copy link
Member

WillAyd commented Jun 6, 2018

Thanks - want to submit a PR to fix?

@WillAyd WillAyd added the Docs label Jun 6, 2018
@pjk645-zz
Copy link
Author

I'm afraid I'm not set up to pull because of my work's firewall and lack of a computer at home (just a smart phone). Maybe I can do it from my phone, but I'm a newbie, so...

@uds5501
Copy link
Contributor

uds5501 commented Jun 7, 2018

@pjk645 you can surely do it via smartphone (but it is gonna be a little tedious).

@gfyoung gfyoung added this to the 0.24.0 milestone Jun 7, 2018
@gfyoung
Copy link
Member

gfyoung commented Jun 7, 2018

Marking this for 0.24.0 to give time for someone to contribute (0.23.1 comes out on Friday), but if no one does, we should / can easily patch this for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants