We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
>>> df1 = pd.DataFrame() >>> df2 = pd.DataFrame({'isBool': [True]}) >>> df1.combine_first(df2) isBool 0 True
>>> df1 = pd.DataFrame({'isInt': [1]}) >>> df2 = pd.DataFrame({'isBool': [True]}) >>> df1.combine_first(df2) isBool isInt 0 1.0 1
Would expect Pandas to preserve the bool dtype (or at least the behavior should differ for the case where df1 is empty or not).
See also: https://stackoverflow.com/questions/39103144/pandas-dataframe-combine-first-method-converts-boolean-in-floats And related: https://stackoverflow.com/questions/15349795/pandas-dataframe-combine-first-and-update-methods-have-strange-behavior And: #3016
Seems to me some of the issues where solved but this case may have escaped(?)
pd.show_versions()
pandas: 0.21.1 pytest: 3.5.0 pip: 9.0.3 setuptools: 38.5.2 Cython: None numpy: 1.13.3 scipy: 1.0.0 pyarrow: None xarray: None IPython: 6.2.1 sphinx: 1.7.1 patsy: None dateutil: 2.7.0 pytz: 2018.3 blosc: None bottleneck: None tables: None numexpr: None feather: None matplotlib: 2.1.1 openpyxl: None xlrd: None xlwt: None xlsxwriter: None lxml: None bs4: None html5lib: 1.0.1 sqlalchemy: None pymysql: None psycopg2: None jinja2: 2.10 s3fs: None fastparquet: None pandas_gbq: None pandas_datareader: None
The text was updated successfully, but these errors were encountered:
I see no reason why dtype shouldn't be preserved. PR to patch is welcome!
dtype
Sorry, something went wrong.
(removed 0.23.1 milestone as this is not a blocker for the release)
Successfully merging a pull request may close this issue.
Works as expected:
Does not work as expected:
Problem description
Would expect Pandas to preserve the bool dtype (or at least the behavior should differ for the case where df1 is empty or not).
See also: https://stackoverflow.com/questions/39103144/pandas-dataframe-combine-first-method-converts-boolean-in-floats
And related: https://stackoverflow.com/questions/15349795/pandas-dataframe-combine-first-and-update-methods-have-strange-behavior
And: #3016
Seems to me some of the issues where solved but this case may have escaped(?)
Output of
pd.show_versions()
:pandas: 0.21.1
pytest: 3.5.0
pip: 9.0.3
setuptools: 38.5.2
Cython: None
numpy: 1.13.3
scipy: 1.0.0
pyarrow: None
xarray: None
IPython: 6.2.1
sphinx: 1.7.1
patsy: None
dateutil: 2.7.0
pytz: 2018.3
blosc: None
bottleneck: None
tables: None
numexpr: None
feather: None
matplotlib: 2.1.1
openpyxl: None
xlrd: None
xlwt: None
xlsxwriter: None
lxml: None
bs4: None
html5lib: 1.0.1
sqlalchemy: None
pymysql: None
psycopg2: None
jinja2: 2.10
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: None
The text was updated successfully, but these errors were encountered: