Skip to content

Unify argument conventions #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jseabold opened this issue Oct 12, 2012 · 4 comments
Closed

Unify argument conventions #2062

jseabold opened this issue Oct 12, 2012 · 4 comments
Labels
Ideas Long-Term Enhancement Discussions

Comments

@jseabold
Copy link
Contributor

I know how hard it can be to stick to conventions, but it might be nice to try to unify arguments that do similar things. For example, the argument to select/name columns is not consistent. I realize it's a bit difficult since columns usually means labels and there's an axis argument. I don't know to what extent it's feasible because of this, but maybe all of these should be column(s)? Or even name(s) since this doesn't imply an axis but can be inferred from context when there's no axis argument. The few that come to mind since I just used them.

dropna -- subset
drop_duplicates -- cols
DataFrame -- columns
Series -- name

Just a thought.

@joeb1415
Copy link

+1.
DataFrame.pivot_table() takes "cols" as an argument. "columns" is more common. Motion to change pivot_table's argument to "columns" instead?

@joeb1415
Copy link

While we're at it with pivot_table, could we accept "index" instead of / in addition to "rows" as a parameter name?

@jreback
Copy link
Contributor

jreback commented Apr 24, 2014

this was fixed by #5505, #6680

@jreback jreback closed this as completed Apr 24, 2014
@jseabold
Copy link
Contributor Author

Fantastic. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ideas Long-Term Enhancement Discussions
Projects
None yet
Development

No branches or pull requests

3 participants