Skip to content

DOC: Documentation Standarization Proposal #20332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adatasetaday opened this issue Mar 13, 2018 · 2 comments
Closed

DOC: Documentation Standarization Proposal #20332

adatasetaday opened this issue Mar 13, 2018 · 2 comments
Labels

Comments

@adatasetaday
Copy link
Contributor

adatasetaday commented Mar 13, 2018

While working on the documentation sprint, I realize that there are a bunch of common issues that are very prevalent through the documentation. Some of them remain after the sprint due to some initial confusion or methods that were not changed during the sprint. Some examples are:

  • period after versionadded (the validating script was asking for it and I know my first two PRs were merged with a period at the end)
  • format of axis parameter's accepted values (I've seen "None, integer or string axis name, optional", "int or string, default 0" and similar instead of "{0 or 'index', 1 or 'columns', None}, default None" type as I saw was agreed on the sprint discussions)
  • return type for methods in generic.py that are used by different classes (i.e. "type of caller" vs. "A new object of same type as caller." vs. "Series or DataFrame")
  • description of methods in "See Also" not matching the summary description of the method (this is mainly due to the high number of changes in the sprint)
  • full method name in "See Also" (i.e. make sure the full path is used but no pandas.)
  • others like the ones suggested in DOC: further clarifications to docstring guide #20309 and DOC: docstring validation script improvements #20298

I am volunteering to do these changes once we deem that all the documentation sprint PRs are completed. I would be creating a different issue for each proposed change to make sure the discussion for each of them is documented and also used to improve the validation scripts in the future.

What are your thought on this?

@TomAugspurger
Copy link
Contributor

Mind moving this over to #20309? I think it overlaps pretty much with it.

@datapythonista
Copy link
Member

Closing in favor of #20298. @adatasetaday if I missed something there, please let me know. And feel free to work in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants