Skip to content

Adding Non-US holidays in pandas.tseries.holiday #19615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cjer opened this issue Feb 9, 2018 · 1 comment
Closed

Adding Non-US holidays in pandas.tseries.holiday #19615

cjer opened this issue Feb 9, 2018 · 1 comment
Labels
Enhancement Usage Question

Comments

@cjer
Copy link

cjer commented Feb 9, 2018

pandas.tseries.holiday has built-in only US holiday calendars. Is it possible to add other countries' holiday calendars to it? This US-centric module seems weird.

Maybe add holidays module, so this is not hard-coded and maintained within pandas.

I could make a pull request for this if it sounds reasonable.
@jreback
Copy link
Contributor

jreback commented Feb 9, 2018

The point of the holidays is to be subclassed, this is only a sample implementation. see also #7070. things like this should live in an external package. they would need there own update frequency and maintainers.

@jreback jreback closed this as completed Feb 9, 2018
@jreback jreback added this to the No action milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Usage Question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jreback @cjer