Skip to content

ASV Benchmarks Broken #19586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd opened this issue Feb 7, 2018 · 2 comments
Closed

ASV Benchmarks Broken #19586

WillAyd opened this issue Feb 7, 2018 · 2 comments

Comments

@WillAyd
Copy link
Member

WillAyd commented Feb 7, 2018

Trying to run asv benchmarks is yielding

File "/Users/williamayd/Git/pandas/asv_bench/benchmarks/gil.py", line 3, in <module>
  from pandas import (DataFrame, Series, rolling_median, rolling_mean,
ImportError: cannot import name 'rolling_median'

3597de0 removed pd.rolling_* functions but it looks like asv_bench/benchmarks/gil.py is still trying to import them, hence the error

cc @topper-123

@mroeschke
Copy link
Member

mroeschke commented Feb 7, 2018

xref #19518

I have this fixed in #19236, so it should be fixed soon.

@WillAyd
Copy link
Member Author

WillAyd commented Feb 7, 2018

Ah OK good to know. I'll close this one out then as it looks like this is already accounted for

@WillAyd WillAyd closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants