Skip to content

core.internals checking hasattr(item, 'reindex_axis') #19243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Jan 15, 2018 · 0 comments · Fixed by #19250
Closed

core.internals checking hasattr(item, 'reindex_axis') #19243

jbrockmendel opened this issue Jan 15, 2018 · 0 comments · Fixed by #19250
Labels
Clean Internals Related to non-user accessible pandas implementation
Milestone

Comments

@jbrockmendel
Copy link
Member

Block and SparseBlock each have a reindex_axis method that is not used anywhere, but a bunch of things in core.internals do a check of the form

if hasattr(new, 'reindex_axis'):
    new = new.values

if hasattr(mask, 'reindex_axis'):
     mask = mask.values

It would be nice to get rid of the unused methods. Any idea what this ducktype checks are actually intending to catch?

@jreback jreback added Internals Related to non-user accessible pandas implementation Clean labels Jan 16, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants