Skip to content

TimedeltaBlock.fillna treats int as second #19233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Jan 13, 2018 · 3 comments
Closed

TimedeltaBlock.fillna treats int as second #19233

jbrockmendel opened this issue Jan 13, 2018 · 3 comments
Labels
Internals Related to non-user accessible pandas implementation

Comments

@jbrockmendel
Copy link
Member

Seems like assuming nanosecond would be more natural, or just refusing to assume.

https://github.com/pandas-dev/pandas/blob/master/pandas/core/internals.py#L1981
@jbrockmendel
Copy link
Member Author

There's only one test that hits this and its benign because it happens to fill with 0.

@jreback
Copy link
Contributor

jreback commented Jan 15, 2018

yeah this is probably not idea, does this show up in user facing code?

@jbrockmendel jbrockmendel mentioned this issue Jan 16, 2018
Closed
13 tasks
@jbrockmendel jbrockmendel added the Internals Related to non-user accessible pandas implementation label Jul 30, 2018
@jbrockmendel jbrockmendel mentioned this issue Jan 10, 2019
Merged
4 tasks
@jbrockmendel
Copy link
Member Author

Closed by #24694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jreback @jbrockmendel