Skip to content

ENH: Timestamp constructor does not accept nanosecond arg #18898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Dec 21, 2017 · 9 comments · Fixed by #19889
Closed

ENH: Timestamp constructor does not accept nanosecond arg #18898

jbrockmendel opened this issue Dec 21, 2017 · 9 comments · Fixed by #19889
Milestone

Comments

@jbrockmendel
Copy link
Member

No description provided.

@sinhrks sinhrks added the Datetime Datetime data dtype label Dec 23, 2017
@jreback jreback changed the title Timestamp constructor does not accept nanosecond arg ENH: Timestamp constructor does not accept nanosecond arg Dec 23, 2017
@jreback jreback added this to the Next Major Release milestone Dec 23, 2017
@jreback
Copy link
Contributor

jreback commented Dec 23, 2017

the kwargs are to mirror datetime.datetime, but we should accept it.

@theperfectscript
Copy link

Hi,
I would like to contribute. Can you point me to what needs to be done?

All the best

@jreback
Copy link
Contributor

jreback commented Dec 31, 2017

@theperfectscript
Copy link

I am a bit confused about where i should put in the tests.

Here https://github.com/pandas-dev/pandas/blob/master/pandas/tests/internals/test_internals.py#L290 ?
@jreback

@jreback
Copy link
Contributor

jreback commented Jan 1, 2018

pandas/tests/scalar/test_timestamp

@jbrockmendel jbrockmendel mentioned this issue Feb 7, 2018
59 tasks
@jreback jreback modified the milestones: Next Major Release, 0.23.0 Feb 27, 2018
@bhavybarca
Copy link

bhavybarca commented Feb 28, 2018

@jreback hi can i take his as my good-first-bug ?

@jorisvandenbossche
Copy link
Member

@bhavybarca There is already an open PR that is about to be merged: #19889

@bhavybarca
Copy link

@jorisvandenbossche is there anything a newbie like me can do, i really want to contribute but cant find any first bugs.
A little help would be appreciated, thanks

@jorisvandenbossche
Copy link
Member

You can go through other issues that are labeled with "good first issue". If you have any question about any of them, feel free to also ask at https://gitter.im/pydata/pandas or post on the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants