-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Timestamp constructor does not accept nanosecond arg #18898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the kwargs are to mirror |
Hi, All the best |
start https://github.com/pandas-dev/pandas/blob/master/pandas/_libs/tslibs/timestamps.pyx#L526 need to add to the signature |
I am a bit confused about where i should put in the tests. Here https://github.com/pandas-dev/pandas/blob/master/pandas/tests/internals/test_internals.py#L290 ? |
pandas/tests/scalar/test_timestamp |
@jreback hi can i take his as my good-first-bug ? |
@bhavybarca There is already an open PR that is about to be merged: #19889 |
@jorisvandenbossche is there anything a newbie like me can do, i really want to contribute but cant find any first bugs. |
You can go through other issues that are labeled with "good first issue". If you have any question about any of them, feel free to also ask at https://gitter.im/pydata/pandas or post on the issue |
No description provided.
The text was updated successfully, but these errors were encountered: