Skip to content

TST: Coding Error in test_disallowed_nodes #18821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Dec 18, 2017 · 1 comment · Fixed by #18847
Closed

TST: Coding Error in test_disallowed_nodes #18821

WillAyd opened this issue Dec 18, 2017 · 1 comment · Fixed by #18847
Labels
Testing pandas testing functions or related to the test suite
Milestone
0.23.0

Comments

@WillAyd
Copy link
Member

WillAyd commented Dec 18, 2017

See permalink below. I believe the engine parameter should be referencing the _engines global and not _parsers

pandas/pandas/tests/computation/test_eval.py

Line 1803 in 7a0ee19

@pytest.mark.parametrize('engine', _parsers)

@WillAyd WillAyd changed the title TST: Coding Error in test_disallowed_nodes TST: Coding Error in test_disallowed_nodes Dec 18, 2017
@WillAyd WillAyd mentioned this issue Dec 19, 2017
Merged
4 tasks
@gfyoung gfyoung added the Testing pandas testing functions or related to the test suite label Dec 19, 2017
@gfyoung
Copy link
Member

gfyoung commented Dec 19, 2017

That would seem logical to do.

@jreback jreback added this to the 0.22.0 milestone Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

Fixed typo in test_eval arguments WillAyd/pandas
3 participants
@WillAyd @jreback @gfyoung