Skip to content

Typo checks in core.ops #18803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Dec 16, 2017 · 4 comments
Closed

Typo checks in core.ops #18803

jbrockmendel opened this issue Dec 16, 2017 · 4 comments
Labels
Clean Timezones Timezone data dtype

Comments

@jbrockmendel
Copy link
Member

https://github.com/pandas-dev/pandas/blob/master/pandas/core/ops.py#L490

            elif (isinstance(ovalues, datetime.datetime) and
                  hasattr(ovalues, 'tzinfo')):

Is that hasattr(ovalues, 'tzinfo') supposed to be ovalues.tzinfo is not None?
@gfyoung gfyoung added the Timezones Timezone data dtype label Dec 17, 2017
@gfyoung
Copy link
Member

gfyoung commented Dec 17, 2017

I can't tell ATM, so change it and find out 😄

@jreback
Copy link
Contributor

jreback commented Dec 18, 2017

do you have an example of something that hits this? I would guess that we have other lines of code which work-around (so this is a no-op).

@jreback jreback added this to the Next Major Release milestone Dec 18, 2017
@jreback jreback added the Clean label Dec 18, 2017
@jbrockmendel
Copy link
Member Author

do you have an example of something that hits this?

pd.date_range('2016-01-01', periods=3).to_series() - pd.Timestamp.now() hits it.

@jbrockmendel
Copy link
Member Author

Closed by #19024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Timezones Timezone data dtype
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jreback @jbrockmendel @gfyoung