Skip to content

CLN: consolidate Index.astype #18704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Dec 9, 2017 · 1 comment · Fixed by #18937
Closed

CLN: consolidate Index.astype #18704

jreback opened this issue Dec 9, 2017 · 1 comment · Fixed by #18937
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Milestone
0.23.0

Comments

@jreback
Copy link
Contributor

jreback commented Dec 9, 2017

we have some code repitiion in *Index.astype, IOW each subclass implements a lot of the same boilerplate / logic. I think we could make this a bit simpler (maybe have a class attribute which Index.astype can check for valid types, and override this in sub-classes). just a thought.

xref #18677
@jreback jreback added Clean Difficulty Intermediate Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves labels Dec 9, 2017
@jreback jreback added this to the Next Major Release milestone Dec 9, 2017
@jreback
Copy link
Contributor Author

jreback commented Dec 9, 2017

cc @jschendel

@jschendel jschendel mentioned this issue Dec 10, 2017
Merged
5 tasks
@jschendel jschendel mentioned this issue Dec 25, 2017
Merged
5 tasks
@jreback jreback modified the milestones: Next Major Release, 0.23.0 Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

CLN/BUG: Consolidate Index.astype and fix tz aware bugs jschendel/pandas
1 participant
@jreback