Skip to content

broken timestamp asvs #18680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Dec 7, 2017 · 1 comment · Fixed by #18684
Closed

broken timestamp asvs #18680

jbrockmendel opened this issue Dec 7, 2017 · 1 comment · Fixed by #18684
Labels
Benchmark Performance (ASV) benchmarks Datetime Datetime data dtype
Milestone

Comments

@jbrockmendel
Copy link
Member

@mroeschke do these indicate incorrectly written benchmarks?

asv continuous -f 1.1 -E virtualenv master HEAD -b timeseries -b timestamp -b timedelta -b period -b offset
[...]
[  1.86%] ··· Running gil.nogil_datetime_fields.time_period_to_datetime                          failed
[  2.13%] ··· Running indexing.AssignTimeseriesIndex.time_frame_assign_timeseries_index          failed
[...]
[ 45.48%] ··· Running timestamp.TimestampProperties.time_dayofweek                               failed
[ 45.74%] ··· Running timestamp.TimestampProperties.time_dayofyear                               failed
[ 46.01%] ··· Running timestamp.TimestampProperties.time_days_in_month                           failed
[ 46.28%] ··· Running timestamp.TimestampProperties.time_freqstr                                 failed
[ 46.54%] ··· Running timestamp.TimestampProperties.time_is_leap_year                            failed
[ 46.81%] ··· Running timestamp.TimestampProperties.time_is_month_end                            failed
[ 47.07%] ··· Running timestamp.TimestampProperties.time_is_month_start                          failed
[ 47.34%] ··· Running timestamp.TimestampProperties.time_is_quarter_end                          failed
[ 47.61%] ··· Running timestamp.TimestampProperties.time_is_quarter_start                        failed
[ 47.87%] ··· Running timestamp.TimestampProperties.time_is_year_end                             failed
[ 48.14%] ··· Running timestamp.TimestampProperties.time_is_year_start                           failed
[ 48.40%] ··· Running timestamp.TimestampProperties.time_microsecond                             failed
[ 48.67%] ··· Running timestamp.TimestampProperties.time_offset                                  failed
[ 48.94%] ··· Running timestamp.TimestampProperties.time_quarter                                 failed
[ 49.20%] ··· Running timestamp.TimestampProperties.time_tz                                      failed
[ 49.47%] ··· Running timestamp.TimestampProperties.time_week                                    failed
[ 49.73%] ··· Running timestamp.TimestampProperties.time_weekday_name                            failed
@mroeschke
Copy link
Member

mroeschke commented Dec 7, 2017

Possibly. asv dev -b timeseries -b timestamp -b timedelta -b period -b offset will return tracebacks if the benchmarks have any errors.

The annoying thing is that sometimes asv dev will say the benchmarks are okay but asv run or asv continuous will still say "failed", not completely sure why...

@gfyoung gfyoung added Benchmark Performance (ASV) benchmarks Datetime Datetime data dtype labels Dec 8, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.22.0 milestone Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants