Skip to content

get_value_box duplication #18299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Nov 15, 2017 · 1 comment · Fixed by #18371
Closed

get_value_box duplication #18299

jbrockmendel opened this issue Nov 15, 2017 · 1 comment · Fixed by #18371
Labels
Clean Internals Related to non-user accessible pandas implementation
Milestone
0.23.0

Comments

@jbrockmendel
Copy link
Member

tslib.get_value_box seems out of place. The only place it is used is in base.index. Meanwhile _libs.index.get_value_at looks very similar but is never used. (It also looks similar to a chunk of code in IndexEngine.get_value

Is it possible that index.get_value_at was intended to replace tslib.get_value_box?
@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Nov 16, 2017
@gfyoung
Copy link
Member

gfyoung commented Nov 16, 2017

@jbrockmendel : Have a look at the blame tab on GitHub for this file. That might be of use, though other maintainers probably know better than I here.

@jbrockmendel jbrockmendel mentioned this issue Nov 19, 2017
Merged
2 tasks
@jreback jreback added this to the 0.22.0 milestone Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

remove get_value_box since it is redundant with libindex.get_value_at jbrockmendel/pandas
3 participants
@jreback @jbrockmendel @gfyoung