Skip to content

DEPR: Remove old-style warnings Categorical init #17485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAugspurger opened this issue Sep 9, 2017 · 1 comment
Closed

DEPR: Remove old-style warnings Categorical init #17485

TomAugspurger opened this issue Sep 9, 2017 · 1 comment
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Sep 9, 2017

See

# there were two ways if categories are present
# - the old one, where each value is a int pointer to the levels
# array -> not anymore possible, but code outside of pandas could
# call us like that, so make some checks
# - the new one, where each value is also in the categories array
# (or np.nan)
# make sure that we always have the same type here, no matter what
# we get passed in
categories = self._validate_categories(categories)
codes = _get_codes_for_values(values, categories)
# TODO: check for old style usage. These warnings should be removes
# after 0.18/ in 2016

@TomAugspurger TomAugspurger added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Sep 9, 2017
@toobaz
Copy link
Member

toobaz commented Nov 12, 2017

Sorry, I had missed this, anyway it was just fixed in #18022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Development

No branches or pull requests

2 participants