Skip to content

Namespace removal #17401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Aug 31, 2017 · 2 comments
Closed

Namespace removal #17401

jbrockmendel opened this issue Aug 31, 2017 · 2 comments
Labels
Clean Internals Related to non-user accessible pandas implementation

Comments

@jbrockmendel
Copy link
Member

There are a few places where methods/attributes have crept into class namespaces that probably don't belong there. Will there be any objections to cleaning up any of the following?

tslib.Timedelta._validate_ops_compat does not use self, can be a cdef function at the module level.

tslib.Timedelta._binary_op_method_timedeltalike doesn't even have self in its args, can be a func at the module level (though it cant be cdef)

tslib.Timedelta._op_unary_method ditto

tslib.Timedelta._round and tslib.Timestamp._round are backend methods that round, floor, ceil call. They could be cdef and not exposed.

_Timestamp._get_field is cpdef, could be cdef and not exposed.
_Timestamp._get_start_end_field ditto

All of these technically break backward compat if there is someone out there using them, but I have a hard time imagining that use case, so think its worth considering.


Outside of tslib, the items in my notes are:

core.groupby.SeriesGroupBy._agg_doc
core.groupby.DataFrameGroupBy._agg_doc
DataFrame._agg_doc

@sinhrks sinhrks added Clean Internals Related to non-user accessible pandas implementation labels Aug 31, 2017
@jbrockmendel
Copy link
Member Author

_Period._comparables appears unused.

@jbrockmendel
Copy link
Member Author

Added figuring these out to the TODO list in #17652. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

No branches or pull requests

2 participants