Skip to content

Travis doc build not run with master anymore #15311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorisvandenbossche opened this issue Feb 5, 2017 · 10 comments · Fixed by #15317
Closed

Travis doc build not run with master anymore #15311

jorisvandenbossche opened this issue Feb 5, 2017 · 10 comments · Fixed by #15317
Labels
CI Continuous Integration Docs
Milestone

Comments

@jorisvandenbossche
Copy link
Member

Since a few commits (but I don't think it is related to one of our commits, rather to conda or so), the docs are run with pandas 0.19.2, and not with master (giving a lot of errors for those code blocks that show new things, see eg here)

The cause seems to be that the installing of r and rpy2 seems to install pandas (https://travis-ci.org/pandas-dev/pandas/jobs/198582770, line 1233 in the log). Before that commit, the build log does not include pandas in that conda output.
The strange thing is also that pandas appears in the conda output as a 'new' package, not one that is up or downgraded. Which seems to indicate that pandas was not yet installed, although the master version seemed to be installed correctly.

@jorisvandenbossche jorisvandenbossche added Build Library building on various platforms Docs labels Feb 5, 2017
@jreback
Copy link
Contributor

jreback commented Feb 5, 2017

so a way to fix

install r things with a separate conda installl

and use --no-deps

@jorisvandenbossche
Copy link
Member Author

They are already a separate conda install, and indeed, tried with --no-deps (test is running on travis, but still on my fork: https://travis-ci.org/jorisvandenbossche/pandas/builds/198665251).
The strange thing is though why this changed (when I install r and rpy2 in a clean env locally, pandas is not added by default, so it's not that the conda-packagers added pandas as a dep of rpy2).

@jreback
Copy link
Contributor

jreback commented Feb 5, 2017

i would guess that rpy maybe is explicitly having pandas as a dep? (and maybe. it before)

another alternative could be to fix the versions

also possible newer conda 'fixes' things (but actually we were relying on broken behavior before)

@jreback
Copy link
Contributor

jreback commented Feb 5, 2017

other thug is we do uninstall pandas as final step (so we will use the sec version)

for example xarray installs pandas as well

@jreback
Copy link
Contributor

jreback commented Feb 6, 2017

you just need this in ci/build-docs.sh

This is what we do at the end of install_travis.sh

    # remove any installed pandas package
    # w/o removing anything else
    echo "[removing installed pandas]"
    conda remove pandas --force

though what I would really do is put these lines in:

    source activate pandas
    conda install -n pandas -c r r rpy2 --yes

    time sudo apt-get $APT_ARGS install dvipng texlive-latex-base texlive-latex-extra

in here

(pandas) bash-3.2$ more ci/requirements-3.5_DOC_BUILD.sh 
#!/bin/bash

source activate pandas

echo "install DOC_BUILD"

conda install -n pandas -c conda-forge feather-format

This is an optional script that gets run to do post conda/pip requirements installs (when completely custom is needed).

@jreback jreback added this to the 0.20.0 milestone Feb 6, 2017
@jreback jreback added the CI Continuous Integration label Feb 6, 2017
@jorisvandenbossche
Copy link
Member Author

Ah, yes, that seems like a better idea. In any case, the test with --no-deps failed as it actually needed some deps (which of course could be figured out which they are and include them in the install command. But if this works that will be easier and more consistent)

Test is here: #15317

@jorisvandenbossche jorisvandenbossche removed the Build Library building on various platforms label Feb 6, 2017
@jreback
Copy link
Contributor

jreback commented Feb 6, 2017

I also temp removed all builds except for this one to make faster (but won't merge that comit): https://travis-ci.org/jreback/pandas/builds/198847359

@jorisvandenbossche
Copy link
Member Author

Ah OK, your commit is fine as well, but updated the PR as well.

@jreback
Copy link
Contributor

jreback commented Feb 6, 2017

yep go ahead with yours is fine.

@jorisvandenbossche
Copy link
Member Author

And from the build on your fork, it seems to work now (the remaining errors in the doc build log are the 'expected' (await fixes as well))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants