Skip to content

RLS: v0.19.2 #14748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorisvandenbossche opened this issue Nov 25, 2016 · 24 comments
Closed

RLS: v0.19.2 #14748

jorisvandenbossche opened this issue Nov 25, 2016 · 24 comments
Labels
Milestone

Comments

@jorisvandenbossche
Copy link
Member

Issue to follow-up 0.19.2 release.

0.19.2 milestoned issues/PRs: https://github.com/pandas-dev/pandas/milestone/45

0.19.1 was released Nov 3. In the meantime already quite some work for 0.19.2 is done (mainly thanks to Jeff!). Main things for 0.19.2 (besides general bug fixes):

The Python 3.6 release schedule is a rc1 at 2016-12-05, and final release at 2016-12-16.

Regarding timeline for pandas 0.19.2, the question is maybe whether we have to wait until after the final Python 3.6 release, or if we can do it earlier (eg after rc1, with the risk there are still some changes)

@pandas-dev/pandas-core

@stonebig
Copy link
Contributor

hi, would it be possible to have a 0.19.2beta BEFORE rc1, to help check there no more bugs in python-3.6.0b4 itself ?

@jreback
Copy link
Contributor

jreback commented Nov 27, 2016

as soon as the latest 3.6 is on conda forge we can build with it - if u want to ping the maintainers

@jreback
Copy link
Contributor

jreback commented Nov 28, 2016

so 3.60b4 is now active (e.g. on this PR): https://travis-ci.org/pandas-dev/pandas/jobs/179477285

@stonebig
Copy link
Contributor

no errors, wonderfull !

@jreback
Copy link
Contributor

jreback commented Nov 28, 2016

@stonebig yeah I don't think any actual changes in the latest betas matters much to us. (I fixed things on 3.60b3)

@stonebig
Copy link
Contributor

stonebig commented Nov 28, 2016

no waiting that Christoph Gohlke does a binary ... you may perhaps tag a beta to trigger it.

@jreback
Copy link
Contributor

jreback commented Nov 28, 2016

@stonebig we don't usually do a pre for a minor release.

@jorisvandenbossche
Copy link
Member Author

@stonebig Are you able to install pandas from master to test?

@stonebig
Copy link
Contributor

the idea was to get a wheel. pythonnet projet generate an artefact wheel on every test on appveyor. would be nice of pandas could too

@jreback
Copy link
Contributor

jreback commented Nov 28, 2016

@stonebig we generate a tremendous number of PR's / commits. Building the package (via wheel) will just add a lot of time to the build, then have to manage the .whl and such. We are already generating conda packages (though not actually doing anything with them).

To be honest I don't really want to do it because it inevitable causes people to use them, and then complain if they are not super backwards compatible (IOW these are usually generated by a modern compiler / arch and not the compatible layers that say conda-forge / anaconda uses).

So I think people should just build from source if they really really need something in-between relatively frequent versions. Instructions are very clear, and even on windows this i quite easy now a days.

@stonebig
Copy link
Contributor

ok, will do a try

@stonebig
Copy link
Contributor

stonebig commented Nov 29, 2016

falling on second line of procedure:

python setup.py build --compiler=mingw32

that cannot possibly be ok on windows for Python-3.6, unless I miss an important detail.

also if I select branch-0.19.x in github, last commit is dated 26 days ago (0.19.1)... I miss a trick on this to get current 0.19.2

@jreback
Copy link
Contributor

jreback commented Nov 29, 2016

http://pandas-docs.github.io/pandas-docs-travis/contributing.html#creating-a-windows-development-environment

@stonebig not sure where you are looking, pls following the instructions above, you must use VS 14 to compiile >= 3.5.

@stonebig
Copy link
Contributor

I was looking at the front page: https://github.com/pandas-dev/pandas

@jorisvandenbossche
Copy link
Member Author

@stonebig That's indeed outdated. I think we can remove almost the full part on installing from source and refer to the docs instead.

@jorisvandenbossche
Copy link
Member Author

I updated the 0.19.x branch with all commits tagged for 0.19.2 (only from yesterday I still have to add), and only few things left on the milestone (https://github.com/pandas-dev/pandas/milestone/45)

Python 3.6 release is due for tomorrow. So we can update our travis build matrix to test with the released version.

I would propose to just release one of the coming days, without looking to much to the python 3.6 build artefacts. As it will probably take some time before the conda-forge / wheel-building machinery are updated to include 3.6 packages.
So I would propose not to wait on that, already release and we can then later upload the 3.6 wheels/conda-packages. Thoughts?

@jreback
Copy link
Contributor

jreback commented Dec 15, 2016 via email

@TomAugspurger
Copy link
Contributor

FYI, 3.6 was delayed a bit: https://mail.python.org/pipermail/python-dev/2016-December/147000.html Now scheduled for the 23rd.

@jreback
Copy link
Contributor

jreback commented Dec 16, 2016

FYI I just updated the matrix. But we are independent of 3.6 releases.

@jreback
Copy link
Contributor

jreback commented Dec 24, 2016

thanks again to @jorisvandenbossche for a great release!

@jreback jreback closed this as completed Dec 24, 2016
@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Dec 24, 2016

Just sent out the announcement. Needed follow-up:

@wesm
Copy link
Member

wesm commented Dec 25, 2016

thank you!

@jorisvandenbossche
Copy link
Member Author

mac osx wheel for python 3.6 is now also available (and uploaded to pypi), see MacPython/pandas-wheels#8

@jorisvandenbossche
Copy link
Member Author

And linux 3.6 wheels are now also available (MacPython/pandas-wheels#9) and uploaded to pypi.
Which means that now everything is uploaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants