-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: add np.nan* functions to map for groupby/rolling/resample aggregators #14518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
@jreback I am willing to work on this problem. I will dig into the tests for this type of mappings shortly! Thanks |
Hi @jreback We are trying to work on this. Hope that's okay. Thanks in advance! :) |
Take |
Closing due to #53974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xref #14517
here we define mappings for numpy functions when they are used in aggregation functions, e.g.
df.groupby(...).apply(np.mean)
is mapped todf.groupby(..).mean()
these are much more performant when used this way and have more typical pandas semantics.
This issue is about adding the
np.nan*
functions (e.g.np.nanmean
) and such.The only thing tricky is that these must be conditionally added based on numpy version, and need testing! (currently tests for this type of mapping is spread across tests for groupby/rolling/resampling), so tests need to be added in various locations, with a possiblity of moving the common parts of this to a single location.
The text was updated successfully, but these errors were encountered: