Skip to content

DOC: read_excel() documentation for na_values should show default na values #13967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bklaas opened this issue Aug 11, 2016 · 3 comments · Fixed by #14073
Closed

DOC: read_excel() documentation for na_values should show default na values #13967

bklaas opened this issue Aug 11, 2016 · 3 comments · Fixed by #14073
Labels
Docs IO Excel read_excel, to_excel
Milestone

Comments

@bklaas
Copy link

bklaas commented Aug 11, 2016

I'd like to see read_excel show the same valid information for na_values as read_csv does. This ended up taking a lot of digging to find because it was unclear what the defaults were with read_excel().

read_csv() documentation shows the following for na_values

na_values : str or list-like or dict, default None
Additional strings to recognize as NA/NaN. If dict passed, specific per-column NA values. By default the following values are interpreted as NaN: ‘’, ‘#N/A’, ‘#N/A N/A’, ‘#NA’, ‘-1.#IND’, ‘-1.#QNAN’, ‘-NaN’, ‘-nan’, ‘1.#IND’, ‘1.#QNAN’, ‘N/A’, ‘NA’, ‘NULL’, ‘NaN’, ‘nan’.

read_excel() documentation does not include default NaN values

na_values : list-like, default None
List of additional strings to recognize as NA/NaN

@sinhrks
Copy link
Member

sinhrks commented Aug 11, 2016

Thx for the suggestion. PR is appreciated!

@sinhrks sinhrks added the Docs label Aug 11, 2016
@jreback jreback added this to the Next Major Release milestone Aug 11, 2016
@jreback jreback added Difficulty Novice IO Excel read_excel, to_excel labels Aug 11, 2016
@jreback jreback changed the title read_excel() documentation for na_values should show default na values DOC: read_excel() documentation for na_values should show default na values Aug 11, 2016
@souravsingh
Copy link

I wish to work on the issue. How do I start?

@jorisvandenbossche
Copy link
Member

First, look at the contributing docs (http://pandas.pydata.org/pandas-docs/stable/contributing.html) which explains how to set-up a development environment and to make a pull request.

Specifically for this change, you can take a look at the read_csv docstring, which includes the correct values for na_values. So you could just copy the explanation from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO Excel read_excel, to_excel
Projects
None yet
5 participants