Skip to content

DEPR/ENH: isleapyear #13727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jul 20, 2016 · 2 comments
Closed

DEPR/ENH: isleapyear #13727

jreback opened this issue Jul 20, 2016 · 2 comments
Labels
Deprecate Functionality to remove in pandas Enhancement

Comments

@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

xref #13706

should deprecate pandas.util.isleapyear
and impement as an accessort to DTI, Timestamp and .dt

@jreback jreback added Enhancement Deprecate Functionality to remove in pandas Difficulty Intermediate labels Jul 20, 2016
@jreback jreback added this to the Next Major Release milestone Jul 20, 2016
@jorisvandenbossche
Copy link
Member

@jreback from #13706 (comment)

I think is_leapyear is fine

leapyear is really the common english word (I see though already getting inconsistent as we should really do is_year_leap)?

No native speaker, but the correct word is "leap year" I think? (and seems also the one most used based on google search).
If that is the case, I think is_leap_year is maybe more consistent with the other options?

@jreback
Copy link
Contributor Author

jreback commented Jul 20, 2016

ok that's fine (slightly inconsistent with is_year_* but oh well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants