-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUILD: build issues on windows #13721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
1st issue is caused by a test case uses |
The second test is getting the content right, but it seems like an issue is what the newline is being read as at the end. For all intensive purposes, can add ".strip()" before the comparison . |
As for the second test: |
@jreback : nit, check both boxes in the issue! |
so from latest master w latest deps
I think some @sinhrks changes for the first
not sure about the 2nd, IIRC @pijucha saw this on windows as well
@gfyoung any idea?d
The text was updated successfully, but these errors were encountered: