Skip to content

BUILD: build issues on windows #13721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
jreback opened this issue Jul 20, 2016 · 5 comments
Closed
2 tasks done

BUILD: build issues on windows #13721

jreback opened this issue Jul 20, 2016 · 5 comments
Labels
Build Library building on various platforms
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

so from latest master w latest deps

======================================================================
ERROR: test_nanosecond_field (pandas.tseries.tests.test_timeseries.TestDatetime64)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\dev\pandas\pandas\tseries\tests\test_timeseries.py", line 3925, in test_nanosecond_field
    dti = DatetimeIndex(np.arange(10))
  File "C:\dev\pandas\pandas\util\decorators.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "C:\dev\pandas\pandas\tseries\index.py", line 337, in __new__
    if isinstance(subarr, DatetimeIndex):
UnboundLocalError: local variable 'subarr' referenced before assignment
======================================================================
FAIL: test_next (pandas.io.tests.test_common.TestMMapWrapper)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\dev\pandas\pandas\io\tests\test_common.py", line 141, in test_next
    self.assertEqual(next_line, line)
AssertionError: 'a,b,c\r\n' != 'a,b,c\n'
- a,b,c
?      -
+ a,b,c

I think some @sinhrks changes for the first
not sure about the 2nd, IIRC @pijucha saw this on windows as well

@gfyoung any idea?d

@jreback jreback added the Build Library building on various platforms label Jul 20, 2016
@jreback jreback added this to the 0.19.0 milestone Jul 20, 2016
@sinhrks
Copy link
Member

sinhrks commented Jul 20, 2016

1st issue is caused by a test case uses np.int32 data (on windows). Will send a PR to fix the condition below.

@gfyoung
Copy link
Member

gfyoung commented Jul 20, 2016

The second test is getting the content right, but it seems like an issue is what the newline is being read as at the end. For all intensive purposes, can add ".strip()" before the comparison .

@pijucha
Copy link
Contributor

pijucha commented Jul 20, 2016

As for the second test:
On windows, I set up git to change newlines to \r\n in a working directory. So the file test_mmap.csv used in this test had \r\n. I noticed readlines() converted them to \n but MMapwrapper didn't.

@jreback
Copy link
Contributor Author

jreback commented Jul 24, 2016

closed by #13736 and #13732

@jreback jreback closed this as completed Jul 24, 2016
@gfyoung
Copy link
Member

gfyoung commented Jul 24, 2016

@jreback : nit, check both boxes in the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

No branches or pull requests

4 participants