Skip to content

GbqConnector should be able to fetch default credentials on Google Compute Engine #13577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhaseebtariq opened this issue Jul 7, 2016 · 2 comments
Milestone

Comments

@mhaseebtariq
Copy link
Contributor

https://github.com/pydata/pandas/blob/master/pandas/io/gbq.py

class GbqConnector(object):
    ...
    def get_user_account_credentials(self):
        ...
    ...

Google Compute Engine and Google Dataproc etc. already have default application credentials on them. Therefore, there is no need of running OAuth2WebServerFlow while the method get_user_account_credentials is being called - instead return GoogleCredentials.get_application_default() is all you need. This change will allow you to run GbqConnector on commandline-only systems on Google Compute Engine without a need of a service account json key.

@jorisvandenbossche
Copy link
Member

cc @parthea @aaront @jacobschaer

@mhaseebtariq
Copy link
Contributor Author

mhaseebtariq commented Jul 7, 2016

Fix for this: #13608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants