Skip to content

Followup to #13358 asof-join #13469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
jreback opened this issue Jun 17, 2016 · 3 comments
Closed
2 tasks

Followup to #13358 asof-join #13469

jreback opened this issue Jun 17, 2016 · 3 comments
Labels
Clean
Milestone
0.19.0

Comments

@jreback
Copy link
Contributor

jreback commented Jun 17, 2016 •
edited
Loading

xref #13358

  • need full signature on deprecated ordered_merge
  • pd.merge_asof() for asof-style time-series joining, see :ref:here <whatsnew_0182.enhancements.asof_merge> for highlites
@jreback jreback added the Clean label Jun 17, 2016
@jreback jreback added this to the 0.18.2 milestone Jun 17, 2016
@jreback
Copy link
Contributor Author

jreback commented Jun 17, 2016

closed by 013c2ce

@jreback jreback closed this as completed Jun 17, 2016
@jreback
Copy link
Contributor Author

jreback commented Jun 17, 2016

@jorisvandenbossche

In merging.rst

I don't understand why there are blank lines between the args for pd.merge, but not for pd.concat

They look exactly the same to me.

@jorisvandenbossche
Copy link
Member

I think it is because of the .. versionadded:: 0.17.0 that is after 'indicator' kwarg for merge. Because of that there is a blank line within that bullet point, leading to sphinx to use more spacing between all bullet points of that list.
So maybe just add the "New in version 0.17.0." as plain text there without needing a blank line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.19.0
Development

No branches or pull requests
2 participants
@jreback @jorisvandenbossche