Skip to content

CLN: unify unicode file handle processing #13401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jun 8, 2016 · 5 comments
Closed

CLN: unify unicode file handle processing #13401

jreback opened this issue Jun 8, 2016 · 5 comments
Labels
Clean IO Data IO issues that don't fit into a more specific label Unicode Unicode strings

Comments

@jreback
Copy link
Contributor

jreback commented Jun 8, 2016

xref #13351 (comment)

We use io/common/_get_handle and io/common/get_filepath_or_buffer in various places in most of the io modules, need to unify encoding handling to a somewhat simpler interface (1 function).

@jreback jreback added IO Data IO issues that don't fit into a more specific label Unicode Unicode strings Difficulty Intermediate Clean labels Jun 8, 2016
@jreback jreback added this to the Next Major Release milestone Jun 8, 2016
@max-sixty
Copy link
Contributor

If this is backported from python 3.6, could it help? https://www.python.org/dev/peps/pep-0519/

@jreback
Copy link
Contributor Author

jreback commented Jun 8, 2016

we already support pathlib and py.path in an ok way _stringify_path. This is more about providing a uniform interface that just works with encoding (and compression, though we are almost there for that). It is not far away, just needs some refactoring.

@jreback
Copy link
Contributor Author

jreback commented Jun 24, 2016

@aterrel want to submit more this so can proceed on #13351 ?

@aterrel
Copy link
Contributor

aterrel commented Jun 24, 2016

Yeah I can look into it more. I worked around the issue in #13351, so I feel it could go in before this issue is fixed.

@mroeschke
Copy link
Member

I think #15008 encompasses this specific point. Close to close as a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean IO Data IO issues that don't fit into a more specific label Unicode Unicode strings
Projects
None yet
Development

No branches or pull requests

5 participants