Skip to content

msgpack reads python 2 string as bytes #12225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chris-b1 opened this issue Feb 3, 2016 · 2 comments
Closed

msgpack reads python 2 string as bytes #12225

chris-b1 opened this issue Feb 3, 2016 · 2 comments
Labels
API Design Error Reporting Incorrect or improved errors from pandas

Comments

@chris-b1
Copy link
Contributor

chris-b1 commented Feb 3, 2016

This maybe is just a doc warning - but caught me by surprise. I would prefer the read_csv behavior, but it would be backwards incompatible.

In [57]: pd.read_csv('path/doesn_exist')
---------------------------------------------------------------------------

IOError: File path/doesn_exist does not exist

In [56]: pd.read_msgpack('path/doesn_exist')
Out[56]: [112, 97, 116, 104, 47, 100, 111, 101, 115, 110, 95, 101, 120, 105, 115, 116]

In [59]: pd.read_msgpack(u'path/doesn_exist')
---------------------------------------------------------------------------
ValueError: path_or_buf needs to be a string file path or file-like
@jreback jreback closed this as completed Feb 3, 2016
@jreback jreback reopened this Feb 3, 2016
@jreback
Copy link
Contributor

jreback commented Feb 3, 2016

xref #5924

@jreback jreback added API Design Msgpack Error Reporting Incorrect or improved errors from pandas labels Feb 3, 2016
@jreback jreback added this to the Next Major Release milestone Feb 3, 2016
@chris-b1
Copy link
Contributor Author

chris-b1 commented Feb 3, 2017

Closed in favor of #15296

@chris-b1 chris-b1 closed this as completed Feb 3, 2017
@chris-b1 chris-b1 modified the milestones: No action, Next Major Release Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

No branches or pull requests

2 participants