-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: other plotting tools via plot accessor #11978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We could probably do this as Also, the standard disclaimer that seaborn does this better |
actually prob all should be added via the plot accessor: http://pandas.pydata.org/pandas-docs/stable/visualization.html#plotting-tools |
Something to consider: Maybe we want to deprecate some of these more complex plot types? For example, seaborn does a better job of scatter matrix than we do... |
absolutely let's do that. any others?
cc @jseabold |
@shoyer: IMO the scatter matrix is a basic plot type that people would want to see for a DataFrame. |
I agree with @shoyer. These plotting methods are rather 'neglected' lately. I think we should either choose to give them more attention, or deprecate them. And personally I think it should not be the focus of pandas. But maybe |
why don't we defer scatter_mattix to seaborn anyhow? so seaborn becomes an optional dep) |
@jreback how well are optional circular dependencies no supported in various packagings? I'm not a heavy pandas user directly, but I also find some quick plot methods convenient, instead of having to look for the appropriate function in another package. about plots in statsmodels: plots are mostly in a minimal maintenance state. There is not much effort for a style update to make them look better, e.g. compared to seaborn, because of a lack of developers. Trying to use seaborn as optional statsmodels dependency to upgrade plots is an idea but doesn't have a champion to look into it and work on it. For many plots the focus of seaborn is exploratory analysis which is more similar to the pandas use, but for us having a model inside the plot is inside out because we need plots inside the models, or after having estimated a model. |
using seaborn (or sm using pandas is no problem here) |
I'm in favor of not duplicating efforts and seaborn take over "statistics-driven" plotting in general. I do agree that quick and dirty DataFrame.plot for basic matplotlib plots is still useful, of course. |
@jreback I was thinking more about the install process, pip, requirements and various distributions. Are those all smart enough by now, or will there be, at least temporary, problems? In statsmodels all plot functions try except protect matplotlib import, but we would still have to watch out for circular module imports when statsmodels reuses seaborn. However, that's a internal problem not a distribution problem. |
well I have been pushing the Ideally we would remove all plotting code from pandas (except for say resampling callback and such). And just defer to various engines. You can do this now via |
👍 |
Received this issue from CodeTriage. Seems like it is already closed issue @jorisvandenbossche could you explain why you reopened the issue? |
From the reversion of this feature in #24912 and discussion within, it appears that there's not much appetite in supporting this directly in an accessor and having a free standing function is fine. Closing. |
scatter_matrix
(deprecate, redirect toseaborn
)andrews_curve
parallel_coordinates
lag_plot
(maybe rename tolag
)autocorrelation_plot
(maybe rename toautocorrelation
?)bootstrap_plot
(maybe rename tobootstrap
?)radviz
I think it would be nice to allow scatter_matrix to be called directly on a DataFrame. Currently,
scatter_matrix
is a separate function that takes a DataFrame as a parameter, but it seems like it would be easy enough to rework to allow it to be called directly on a DataFrame as well. Effectively, the convenience function would look something like:Is this feature feasible?
The text was updated successfully, but these errors were encountered: