-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: position indexing in getitem with duplicated index #11747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
Removing the |
This works on master, needs test |
take |
Hi, I am planning on putting the tests in |
perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in py3, the following should correctly raise an
IndexError
however
a positional indexer that is in the range should work
s[3]
Further more, this must be a monotonic increasing duplicated index to trigger
simple change needed here
in that if its an integer and in the range of the index it can return that value.
Though maybe we should just detect this in the cython code (
index.pyx/Index/_get_loc_duplicated
)needless to say, no tests for this :<
The text was updated successfully, but these errors were encountered: