Skip to content

BUG: merge on should accept Series #11323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Oct 14, 2015 · 1 comment
Closed

BUG: merge on should accept Series #11323

jreback opened this issue Oct 14, 2015 · 1 comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Comments

@jreback
Copy link
Contributor

jreback commented Oct 14, 2015

Prob need a better example, but xref #2996

these should accept Series (and align)!

In [47]: x = DataFrame({'A' : list('aabb'), 'B' : [1,2,3,4]})

In [48]: x.merge(x, left_on=['A','B'], right_on=['A',x['B']], how='left')
TypeError: 'Series' does not have the buffer interface

In [49]: x.merge(x, left_on=['A','B'], right_on=['A','B'], how='left')
Out[49]: 
   A  B
0  a  1
1  a  2
2  b  3
3  b  4
@jreback jreback added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Oct 14, 2015
@jreback jreback added this to the Next Major Release milestone Oct 14, 2015
@TomAugspurger
Copy link
Contributor

This was done in 0.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

No branches or pull requests

2 participants