Skip to content

Commit fd90053

Browse files
committed
ENH: more helpful error message when nothing passed to reindex, close #1267
1 parent 16b18c3 commit fd90053

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

RELEASE.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ pandas 0.8.0
7474
- Add histogram / kde plot options for scatter_matrix diagonals (#1237)
7575
- Add inplace option to Series/DataFrame.rename and sort_index,
7676
DataFrame.drop_duplicates (#805, #207)
77+
- More helpful error message when nothing passed to Series.reindex (#1267)
7778

7879
**API Changes**
7980

pandas/core/series.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1983,6 +1983,9 @@ def reindex(self, index=None, method=None, level=None, fill_value=np.nan,
19831983
-------
19841984
reindexed : Series
19851985
"""
1986+
if index is None:
1987+
raise ValueError('Must pass Index or sequence, not None')
1988+
19861989
index = _ensure_index(index)
19871990
if self.index.equals(index):
19881991
if copy:

pandas/tests/test_series.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2236,6 +2236,8 @@ def test_reindex(self):
22362236
for idx, val in subNonContig.iteritems():
22372237
self.assertEqual(val, self.ts[idx])
22382238

2239+
self.assertRaises(ValueError, self.ts.reindex)
2240+
22392241
def test_reindex_corner(self):
22402242
# (don't forget to fix this) I think it's fixed
22412243
reindexed_dep = self.empty.reindex(self.ts.index, method='pad')

0 commit comments

Comments
 (0)