Skip to content

Commit fbc602c

Browse files
committed
Apply "black" styling and fix typo
This should hopefully resolve remaining linter issues.
1 parent d7b42e3 commit fbc602c

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

pandas/core/groupby/ops.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -955,8 +955,9 @@ class SeriesSplitter(DataSplitter):
955955
def _chop(self, sdata: Series, slice_obj: slice) -> Series:
956956
# fastpath equivalent to `sdata.iloc[slice_obj]`
957957
mgr = sdata._mgr.get_slice(slice_obj)
958-
return sdata._constructor(mgr, name=sdata.name, fastpath=True)\
959-
.__finalize__(sdata, method='groupby')
958+
return sdata._constructor(mgr, name=sdata.name, fastpath=True).__finalize__(
959+
sdata, method="groupby"
960+
)
960961

961962

962963
class FrameSplitter(DataSplitter):
@@ -972,7 +973,7 @@ def _chop(self, sdata: DataFrame, slice_obj: slice) -> DataFrame:
972973
# else:
973974
# return sdata.iloc[:, slice_obj]
974975
mgr = sdata._mgr.get_slice(slice_obj, axis=1 - self.axis)
975-
return sdata._constructor(mgr).__finalize__(sdata, method='groupby')
976+
return sdata._constructor(mgr).__finalize__(sdata, method="groupby")
976977

977978

978979
def get_splitter(

pandas/tests/groupby/test_custom_metadata.py

+16-13
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
from typing import List
1515

1616

17-
_TABLE_METADATA_FIELD_NAME = '_pandastable_metadata'
17+
_TABLE_METADATA_FIELD_NAME = "_pandastable_metadata"
1818

1919

2020
def _combine_metadata(data: List[str]) -> str:
2121
"""
2222
A mock implementation for testing
2323
"""
24-
return '+'.join(data)
24+
return "+".join(data)
2525

2626

2727
class PandasTable(pd.DataFrame):
@@ -37,49 +37,52 @@ def _constructor(self):
3737

3838
def __finalize__(self, other, method=None, **kwargs):
3939
"""
40-
This method be called after constructor to populate metadata
40+
This method will be called after constructor to populate metadata
4141
4242
The "method" argument is subject to change and must be handled robustly.
4343
"""
4444
src = [other] # more logic here in actual implementation
4545
metadata = _combine_metadata(
46-
[d.get_metadata() for d in src if isinstance(d, PandasTable)])
46+
[d.get_metadata() for d in src if isinstance(d, PandasTable)]
47+
)
4748

4849
if not metadata:
49-
warn('__finalize__ unable to combine metadata for method "{method}", '
50-
'falling back to DataFrame')
50+
warn(
51+
'__finalize__ unable to combine metadata for method "{method}", '
52+
"falling back to DataFrame"
53+
)
5154
return pd.DataFrame(self)
5255
object.__setattr__(self, _TABLE_METADATA_FIELD_NAME, metadata)
5356
return self
5457

5558
def get_metadata(self):
5659
metadata = getattr(self, _TABLE_METADATA_FIELD_NAME, None)
5760
if metadata is None:
58-
warn('PandasTable object not correctly initialized: no metadata')
61+
warn("PandasTable object not correctly initialized: no metadata")
5962
return metadata
6063

6164
@staticmethod
62-
def from_table_data(df: pd.DataFrame, metadata) -> 'PandasTable':
65+
def from_table_data(df: pd.DataFrame, metadata) -> "PandasTable":
6366
df = PandasTable(df)
6467
object.__setattr__(df, _TABLE_METADATA_FIELD_NAME, metadata)
6568
return df
6669

6770

6871
@pytest.fixture
6972
def dft():
70-
df = pd.DataFrame([[11, 12, 0], [21, 22, 0], [31, 32, 1]], columns={'a', 'b', 'g'})
71-
return PandasTable.from_table_data(df, 'My metadata')
73+
df = pd.DataFrame([[11, 12, 0], [21, 22, 0], [31, 32, 1]], columns={"a", "b", "g"})
74+
return PandasTable.from_table_data(df, "My metadata")
7275

7376

7477
def test_initial_metadata(dft):
75-
assert dft.get_metadata() == 'My metadata'
78+
assert dft.get_metadata() == "My metadata"
7679

7780

7881
def test_basic_propagation(dft):
7982
gg = dft.loc[dft.g == 0, :]
80-
assert gg.get_metadata() == 'My metadata'
83+
assert gg.get_metadata() == "My metadata"
8184

8285

8386
def test_groupby(dft):
84-
gg = [ab for g, ab in dft.groupby('g')]
87+
gg = [ab for g, ab in dft.groupby("g")]
8588
assert gg[0].get_metadata() is not None

0 commit comments

Comments
 (0)