Skip to content

Commit f6a8a6d

Browse files
author
TomAugspurger
committed
DEPR: deprecate convert_dummies
add depr to doc
1 parent 78ccfac commit f6a8a6d

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

doc/source/v0.15.0.txt

+3
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,9 @@ There are no prior version deprecations that are taking effect as of 0.15.0.
417417
Deprecations
418418
~~~~~~~~~~~~
419419

420+
The ``convert_dummies`` method has been deprecated in favor of
421+
``get_dummies``(:issue:`8140`)
422+
420423
.. _whatsnew_0150.knownissues:
421424

422425
Known Issues

pandas/core/reshape.py

+6
Original file line numberDiff line numberDiff line change
@@ -979,6 +979,12 @@ def convert_dummies(data, cat_variables, prefix_sep='_'):
979979
-------
980980
dummies : DataFrame
981981
"""
982+
import warnings
983+
984+
warnings.warn("'convert_dummies' is deprecated and will be removed "
985+
"in a future release. Use 'get_dummies' instead.",
986+
FutureWarning)
987+
982988
result = data.drop(cat_variables, axis=1)
983989
for variable in cat_variables:
984990
dummies = _get_dummies_1d(data[variable], prefix=variable,

pandas/tests/test_reshape.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,9 @@ def test_convert_dummies(self):
331331
'C': np.random.randn(8),
332332
'D': np.random.randn(8)})
333333

334-
result = convert_dummies(df, ['A', 'B'])
335-
result2 = convert_dummies(df, ['A', 'B'], prefix_sep='.')
334+
with tm.assert_produces_warning(FutureWarning):
335+
result = convert_dummies(df, ['A', 'B'])
336+
result2 = convert_dummies(df, ['A', 'B'], prefix_sep='.')
336337

337338
expected = DataFrame({'A_foo': [1, 0, 1, 0, 1, 0, 1, 1],
338339
'A_bar': [0, 1, 0, 1, 0, 1, 0, 0],

0 commit comments

Comments
 (0)