Skip to content

Commit f3686ee

Browse files
committed
Address merge comments
1 parent 1dc26af commit f3686ee

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

pandas/core/groupby/groupby.py

+4-12
Original file line numberDiff line numberDiff line change
@@ -1743,12 +1743,8 @@ def cummin(self, axis=0, **kwargs):
17431743
if axis != 0:
17441744
return self.apply(lambda x: np.minimum.accumulate(x, axis))
17451745

1746-
if kwargs.get('numeric_only') or False:
1747-
numeric_only = kwargs.get('numeric_only')
1748-
else:
1749-
numeric_only = False
1750-
1751-
return self._cython_transform('cummin', numeric_only=numeric_only)
1746+
return self._cython_transform('cummin',
1747+
numeric_only=kwargs.get('numeric_only') or False)
17521748

17531749
@Substitution(name='groupby')
17541750
@Appender(_doc_template)
@@ -1757,12 +1753,8 @@ def cummax(self, axis=0, **kwargs):
17571753
if axis != 0:
17581754
return self.apply(lambda x: np.maximum.accumulate(x, axis))
17591755

1760-
if kwargs:
1761-
numeric_only = kwargs.get('numeric_only')
1762-
else:
1763-
numeric_only = False
1764-
1765-
return self._cython_transform('cummax', numeric_only=numeric_only)
1756+
return self._cython_transform('cummax',
1757+
numeric_only=kwargs.get('numeric_only') or False)
17661758

17671759
def _get_cythonized_result(self, how, grouper, aggregate=False,
17681760
cython_dtype=None, needs_values=False,

pandas/io/pytables.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -3971,7 +3971,8 @@ def write(self, obj, axes=None, append=False, complib=None,
39713971

39723972
# create the axes
39733973
self.create_axes(axes=axes, obj=obj, validate=append,
3974-
min_itemsize=min_itemsize, **kwargs)
3974+
min_itemsize=min_itemsize,
3975+
**kwargs)
39753976

39763977
for a in self.axes:
39773978
a.validate(self, append)

0 commit comments

Comments
 (0)