Skip to content

Commit f294147

Browse files
committed
Address comments from Tom
1 parent fdb0ce7 commit f294147

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

doc/source/whatsnew/v0.24.0.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ Deprecations
240240
- :meth:`DataFrame.to_stata`, :meth:`read_stata`, :class:`StataReader` and :class:`StataWriter` have deprecated the ``encoding`` argument. The encoding of a Stata dta file is determined by the file type and cannot be changed (:issue:`21244`).
241241
- :meth:`MultiIndex.to_hierarchical` is deprecated and will be removed in a future version (:issue:`21613`)
242242
- :meth:`Series.ptp` is deprecated. Use ``numpy.ptp`` instead (:issue:`21614`)
243-
- :meth:`Categorical.from_codes` has deprecated providing float values for the ``codes`` argument.
243+
- :meth:`Categorical.from_codes` has deprecated providing float values for the ``codes`` argument. (:issue:`21767`)
244244

245245
.. _whatsnew_0240.prior_deprecations:
246246

@@ -288,7 +288,7 @@ Bug Fixes
288288
Categorical
289289
^^^^^^^^^^^
290290

291-
- Bug in :meth:`Categorical.from_codes` where ``NaN`` values in `codes` were silently converted to ``0`` (:issue:`21767`)
291+
- Bug in :meth:`Categorical.from_codes` where ``NaN`` values in `codes` were silently converted to ``0`` (:issue:`21767`). In the future this will raise a ``ValueError``. Also changes the behavior of `.from_codes([1.1, 2.0])`.
292292

293293
Datetimelike
294294
^^^^^^^^^^^^

0 commit comments

Comments
 (0)