Suppress warnings

WillAyd · WillAyd · commit f24c79f3af97 · 2025-01-06T17:56:21.000-05:00
diff --git a/meson.build b/meson.build
@@ -11,6 +11,8 @@ project(
         'cpp_std=c++20',
         'warning_level=2',
         'default_library=static',
+        # TODO: how can we only set this for nanobind?
+        'cpp_args=-Wno-sign-compare'
     ]
 )
 
diff --git a/pandas/_libs/arrow_string_accumulations.cc b/pandas/_libs/arrow_string_accumulations.cc
@@ -143,7 +143,7 @@ class ArrowStringAccumulation {
     ArrowArrayStreamMove(stream, stream_.get());
   }
 
-  std::pair<nb::capsule, nb::capsule> Accumulate(nb::object requested_schema) {
+  std::pair<nb::capsule, nb::capsule> Accumulate(nb::object) {
     struct ArrowSchemaView schema_view{};
     NANOARROW_THROW_NOT_OK(
         ArrowSchemaViewInit(&schema_view, schema_.get(), nullptr));

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@ project(`
`11`	`11`	`'cpp_std=c++20',`
`12`	`12`	`'warning_level=2',`
`13`	`13`	`'default_library=static',`
	`14`	`+ # TODO: how can we only set this for nanobind?`
	`15`	`+ 'cpp_args=-Wno-sign-compare'`
`14`	`16`	`]`
`15`	`17`	`)`
`16`	`18`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ class ArrowStringAccumulation {`
`143`	`143`	`ArrowArrayStreamMove(stream, stream_.get());`
`144`	`144`	`}`
`145`	`145`
`146`		`- std::pair<nb::capsule, nb::capsule> Accumulate(nb::object requested_schema) {`
	`146`	`+ std::pair<nb::capsule, nb::capsule> Accumulate(nb::object) {`
`147`	`147`	`struct ArrowSchemaView schema_view{};`
`148`	`148`	`NANOARROW_THROW_NOT_OK(`
`149`	`149`	`ArrowSchemaViewInit(&schema_view, schema_.get(), nullptr));`