Skip to content

Commit f17a0f4

Browse files
committed
Some border style tests
1 parent 1a8818f commit f17a0f4

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

pandas/formats/excel.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def build_border(self, props):
144144
} for side in ['top', 'right', 'bottom', 'left']}
145145

146146
def _border_style(self, style, width):
147-
# TODO: convert styles and widths to openxml, one of:
147+
# convert styles and widths to openxml, one of:
148148
# 'dashDot'
149149
# 'dashDotDot'
150150
# 'dashed'

pandas/tests/formats/test_to_excel.py

+12
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,18 @@
8484
'patternType': 'solid'}}),
8585
# BORDER
8686
# - style
87+
# TODO: need to check this produces valid OpenXML without color
88+
('border-style: solid',
89+
{'border': {'top': {'style': 'medium'},
90+
'bottom': {'style': 'medium'},
91+
'left': {'style': 'medium'},
92+
'right': {'style': 'medium'}}}),
93+
('border-top-style: solid',
94+
{'border': {'top': {'style': 'medium'}}}),
95+
('border-top-style: dotted',
96+
{'border': {'top': {'style': 'mediumDashDotDot'}}}),
97+
('border-top-style: dashed',
98+
{'border': {'top': {'style': 'mediumDashed'}}}),
8799
# - color
88100
# ALIGNMENT
89101
# - horizontal

0 commit comments

Comments
 (0)