Skip to content

Commit ecf3c15

Browse files
author
Nicholas Ver Halen
committed
Added correct version test and changed whatsnew
1 parent 12a3dca commit ecf3c15

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

doc/source/whatsnew/v0.19.1.txt

-1
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,3 @@ Bug Fixes
5959
- Bug in ``df.groupby`` where ``TypeError`` raised when ``pd.Grouper(key=...)`` is passed in a list (:issue:`14334`)
6060
- Bug in ``pd.pivot_table`` may raise ``TypeError`` or ``ValueError`` when ``index`` or ``columns``
6161
is not scalar and ``values`` is not specified (:issue:`14380`)
62-
- Bug in ``pd.to_numeric`` where a 0 was not unsigned on a downcast = 'unsigned' argument (:issue:`14401`)

doc/source/whatsnew/v0.19.2.txt

+1
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,4 @@ Bug Fixes
2525

2626
- compat with ``dateutil==2.6.0`` for testing (:issue:`14621`)
2727
- allow ``nanoseconds`` in ``Timestamp.replace`` kwargs (:issue:`14621`)
28+
- Bug in ``pd.to_numeric`` where a 0 was not unsigned on a downcast = 'unsigned' argument (:issue:`14401`)

pandas/tools/tests/test_util.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@
22
import locale
33
import codecs
44
import nose
5-
from distutils.version import LooseVersion
65

76
import numpy as np
87
from numpy import (iinfo, int8, int16, int32, int64,
98
uint8, uint16, uint32,)
109

1110
import pandas as pd
12-
from pandas import date_range, Index
11+
from pandas import (date_range, Index, _np_version_under1p9)
1312
import pandas.util.testing as tm
1413
from pandas.tools.util import cartesian_product, to_numeric
1514

@@ -407,8 +406,8 @@ def test_downcast(self):
407406
def test_downcast_limits(self):
408407
# Test the limits of each downcast. Bug: #14401.
409408
# Check to make sure numpy is new enough to run this test.
410-
if LooseVersion(np.__version__) <= LooseVersion('1.8.2'):
411-
return
409+
if _np_version_under1p9:
410+
raise nose.SkipTest("Numpy version is under 1.9")
412411

413412
i = 'integer'
414413
u = 'unsigned'

0 commit comments

Comments
 (0)