Raise OptionError instead of KeyError in __getattr__. Fixes #19789. (#19790)

Author: jayfoad

doc/source/whatsnew/v0.23.0.txt

@@ -909,3 +909,4 @@ Other
 ^^^^^
 
 - Improved error message when attempting to use a Python keyword as an identifier in a ``numexpr`` backed query (:issue:`18221`)
+- Bug in accessing a :func:`pandas.get_option`, which raised ``KeyError`` rather than ``OptionError`` when looking up a non-existant option key in some cases (:issue:`19789`)

pandas/core/config.py

@@ -196,7 +196,10 @@ def __getattr__(self, key):
         if prefix:
             prefix += "."
         prefix += key
-        v = object.__getattribute__(self, "d")[key]
+        try:
+            v = object.__getattribute__(self, "d")[key]
+        except KeyError:
+            raise OptionError("No such option")
         if isinstance(v, dict):
             return DictWrapper(v, prefix)
         else:

pandas/tests/test_config.py

@@ -428,3 +428,9 @@ def test_option_context_scope(self):
 
         # Ensure the current context is reset
         assert self.cf.get_option(option_name) == original_value
+
+    def test_dictwrapper_getattr(self):
+        options = self.cf.options
+        # GH 19789
+        pytest.raises(self.cf.OptionError, getattr, options, 'bananas')
+        assert not hasattr(options, 'bananas')