Don't use unittest.mock

Author: tswast

pandas/tests/io/test_gbq.py

@@ -1,7 +1,6 @@
 from datetime import datetime
 import os
 import platform
-from unittest import mock
 
 import numpy as np
 import pytest
@@ -91,39 +90,59 @@ def make_mixed_dataframe_v2(test_size):
                      index=range(test_size))
 
 
-@mock.patch('pandas_gbq.read_gbq')
-def test_read_gbq_with_deprecated_kwargs(mock_read_gbq):
+def test_read_gbq_with_deprecated_kwargs(monkeypatch):
+    captured_kwargs = {}
+
+    def mock_read_gbq(sql, **kwargs):
+        captured_kwargs.update(kwargs)
+        return DataFrame([[1.0]])
+
+    monkeypatch.setattr("pandas_gbq.read_gbq", mock_read_gbq)
     private_key = object()
-    mock_read_gbq.return_value = DataFrame([[1.0]])
     pd.read_gbq("SELECT 1", verbose=True, private_key=private_key)
-    _, kwargs = mock_read_gbq.call_args
-    assert kwargs["verbose"]
-    assert kwargs["private_key"] is private_key
+
+    assert captured_kwargs["verbose"]
+    assert captured_kwargs["private_key"] is private_key
 
 
-@mock.patch('pandas_gbq.read_gbq')
-def test_read_gbq_without_deprecated_kwargs(mock_read_gbq):
-    mock_read_gbq.return_value = DataFrame([[1.0]])
+def test_read_gbq_without_deprecated_kwargs(monkeypatch):
+    captured_kwargs = {}
+
+    def mock_read_gbq(sql, **kwargs):
+        captured_kwargs.update(kwargs)
+        return DataFrame([[1.0]])
+
+    monkeypatch.setattr("pandas_gbq.read_gbq", mock_read_gbq)
     pd.read_gbq("SELECT 1")
-    _, kwargs = mock_read_gbq.call_args
-    assert "verbose" not in kwargs
-    assert "private_key" not in kwargs
+
+    assert "verbose" not in captured_kwargs
+    assert "private_key" not in captured_kwargs
 
 
-@mock.patch('pandas_gbq.read_gbq')
-def test_read_gbq_with_new_kwargs(mock_read_gbq):
-    mock_read_gbq.return_value = DataFrame([[1.0]])
+def test_read_gbq_with_new_kwargs(monkeypatch):
+    captured_kwargs = {}
+
+    def mock_read_gbq(sql, **kwargs):
+        captured_kwargs.update(kwargs)
+        return DataFrame([[1.0]])
+
+    monkeypatch.setattr("pandas_gbq.read_gbq", mock_read_gbq)
     pd.read_gbq("SELECT 1", use_bqstorage_api=True)
-    _, kwargs = mock_read_gbq.call_args
-    assert kwargs["use_bqstorage_api"]
+
+    assert captured_kwargs["use_bqstorage_api"]
 
 
-@mock.patch('pandas_gbq.read_gbq')
-def test_read_gbq_without_new_kwargs(mock_read_gbq):
-    mock_read_gbq.return_value = DataFrame([[1.0]])
+def test_read_gbq_without_new_kwargs(monkeypatch):
+    captured_kwargs = {}
+
+    def mock_read_gbq(sql, **kwargs):
+        captured_kwargs.update(kwargs)
+        return DataFrame([[1.0]])
+
+    monkeypatch.setattr("pandas_gbq.read_gbq", mock_read_gbq)
     pd.read_gbq("SELECT 1")
-    _, kwargs = mock_read_gbq.call_args
-    assert "use_bqstorage_api" not in kwargs
+
+    assert "use_bqstorage_api" not in captured_kwargs
 
 
 @pytest.mark.single