BUG: Correct crosstabl for categorical inputs

Change catch types to reflect error changes

closes #37465

Author: bashtage

doc/source/whatsnew/v1.1.4.rst

@@ -29,6 +29,7 @@ Fixed regressions
 - Fixed regression in :class:`StataReader` which required ``chunksize`` to be manually set when using an iterator to read a dataset (:issue:`37280`)
 - Fixed regression in setitem with :meth:`DataFrame.iloc` which raised error when trying to set a value while filtering with a boolean list (:issue:`36741`)
 - Fixed regression in :attr:`MultiIndex.is_monotonic_increasing` returning wrong results with ``NaN`` in at least one of the levels (:issue:`37220`)
+- Fixed regression in :meth:`crosstab` that failed when the input series are categorical. (:issue:`37465`)
 
 .. ---------------------------------------------------------------------------
 

pandas/core/reshape/pivot.py

@@ -329,8 +329,7 @@ def _all_key(key):
                 piece = piece.copy()
                 try:
                     piece[all_key] = margin[key]
-                except TypeError:
-
+                except (TypeError, ValueError):
                     # we cannot reshape, so coerce the axis
                     piece.set_axis(
                         piece._get_axis(cat_axis)._to_safe_for_reshape(),

pandas/tests/reshape/test_crosstab.py

@@ -743,3 +743,15 @@ def test_margin_normalize_multiple_columns(self):
         )
         expected.index.name = "C"
         tm.assert_frame_equal(result, expected)
+
+
+def test_categoricals():
+    g = np.random.RandomState(25982704)
+    a = Series(g.randint(0, 3, size=100)).astype("category")
+    b = Series(g.randint(0, 2, size=100)).astype("category")
+    result = crosstab(a, b, margins=True, dropna=False)
+    columns = Index([0, 1, "All"], dtype="object", name="col_0")
+    index = Index([0, 1, 2, "All"], dtype="object", name="row_0")
+    values = [[18, 16, 34], [18, 16, 34], [16, 16, 32], [52, 48, 100]]
+    expected = DataFrame(values, index, columns)
+    tm.assert_frame_equal(result, expected)